Skip to content

Conversation

@jaimergp
Copy link
Contributor

Description

Running asv check will fail on current main due to this incomplete function signature. time_* functions need (apparently) to accept all the parameters specified in the class (a total of six, in this case). They can also admit an arbitrary number of arguments with *args, which is the proposed fix.

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.

Copy link
Contributor

@grlee77 grlee77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. current CI won't test this, so will go ahead and merge now

@grlee77 grlee77 merged commit f93e6ef into scikit-image:main Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants