rename greycomatrix and greycoprops. prefer "gray" in documentation#5385
Merged
alexdesiqueira merged 8 commits intoscikit-image:mainfrom May 12, 2021
Merged
Conversation
|
Hello @grlee77! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-05-11 15:55:07 UTC |
Member
I find that it's okay for this particular change. I would be like @JDWarner on this one 😉 |
mkcor
approved these changes
May 11, 2021
Member
|
Looks great! Thank you @grlee77! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
partially resolves #2604 (following the trend of previous work in the color module for rgb2grey->rgb2gray, etc)
The first commit deals initiates a deprecation for:
greycomatrix->graycomatrixgreycoprops->graycopropsMy main question for that commit is the version to set for the deprecation. I have it as 1.0, but am fine with increasing it to a subsequent release if we want to give at least 2 releases before removing the old functions.
The remaining commits involve consistently using gray rather than grey in the documentation.
I can address the remaining uses of grey in functions and filenames in the morphology module in a separate PR.
Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.