Skip to content

Blacklist pillow 7.1.0, see #4548#4551

Merged
rfezzani merged 5 commits intoscikit-image:masterfrom
sciunto:pillow
Apr 3, 2020
Merged

Blacklist pillow 7.1.0, see #4548#4551
rfezzani merged 5 commits intoscikit-image:masterfrom
sciunto:pillow

Conversation

@sciunto
Copy link
Copy Markdown
Member

@sciunto sciunto commented Apr 3, 2020

Description

See #4548

Checklist

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • Consider backporting the PR with @meeseeksdev backport to v0.14.x

@sciunto sciunto requested a review from hmaarrfk April 3, 2020 12:24
@sciunto sciunto added this to the 0.17 milestone Apr 3, 2020
@hugovk
Copy link
Copy Markdown
Contributor

hugovk commented Apr 3, 2020 

../../venv/lib/python3.7/site-packages/PIL/PngImagePlugin.py:748: in seek
    self._seek(f)
../../venv/lib/python3.7/site-packages/PIL/PngImagePlugin.py:791: in _seek
    cid, pos, length = self.png.read()
E   AttributeError: 'NoneType' object has no attribute 'read'

This next error is python-pillow/Pillow#4518, which has a PR python-pillow/Pillow#4518.

Would you be able to do a test build with the branch from python-pillow/Pillow#4518, so we can see a) it fixes this, and b) there's no other regressions?

Thank you!

@hmaarrfk
Copy link
Copy Markdown
Member

hmaarrfk commented Apr 3, 2020

can you out the link to the issue in the list of dependencies?

@sciunto
Copy link
Copy Markdown
Member Author

sciunto commented Apr 3, 2020

Good idea. It's done, And I did it retrospectively for imread I blacklisted last week.

@sciunto
Copy link
Copy Markdown
Member Author

sciunto commented Apr 3, 2020

Oops, I did it incorrectly I'm fixing it.

This was referenced Apr 3, 2020
Closed
Merged
@emmanuelle
Copy link
Copy Markdown
Member

emmanuelle commented Apr 3, 2020

In order to fix rapidly the CI, mayve @sciunto you can pin to versions < 7.0 and try in another PR to use the Pillow branch mentioned by @hugovk?

@hmaarrfk
Copy link
Copy Markdown
Member

hmaarrfk commented Apr 3, 2020

just also blacklist 7.1.1

@hugovk
Copy link
Copy Markdown
Contributor

hugovk commented Apr 3, 2020

Yep, pillow>=4.3.0,!=7.1.0,!=7.1.1 should do it.

@emmanuelle emmanuelle self-requested a review April 3, 2020 18:44
emmanuelle
emmanuelle approved these changes Apr 3, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@emmanuelle emmanuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sciunto! Let's merge this quickly so that our CI is green again.

rfezzani
rfezzani approved these changes Apr 3, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@rfezzani rfezzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Excellent, thank you @sciunto .

@rfezzani rfezzani merged commit e094b38 into scikit-image:master Apr 3, 2020
@sciunto sciunto deleted the pillow branch April 3, 2020 21:42
This was referenced Apr 4, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmanuelle emmanuelle emmanuelle approved these changes

@hmaarrfk hmaarrfk Awaiting requested review from hmaarrfk

+1 more reviewer

@rfezzani rfezzani rfezzani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.17

Development

Successfully merging this pull request may close these issues.

5 participants

@sciunto @hugovk @hmaarrfk @emmanuelle @rfezzani