Use functools instead of a real function for the internal warn function#4062
Merged
jni merged 2 commits intoscikit-image:masterfrom Jul 30, 2019
Merged
Use functools instead of a real function for the internal warn function#4062jni merged 2 commits intoscikit-image:masterfrom
jni merged 2 commits intoscikit-image:masterfrom
Conversation
41a1013 to
dce8699
Compare
9 tasks
sciunto
approved these changes
Jul 30, 2019
Member
|
@hmaarrfk please rebase and merge. |
Member
|
@sciunto no need for rebasing when GitHub lets you resolve conflicts on the web interface now! =) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As is the internal warn function is just broken, and used badly everywhere in the library.
This PR is a 3 liner stopgap to improve the library.
See #3467 for more in depth discussion.
Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.@meeseeksdev backport to v0.14.x