Skip to content

Improvement: MNT: don't use filter_warnings in test suite.#3459

Merged
stefanv merged 1 commit intoscikit-image:masterfrom
hmaarrfk:dont_use_filter_warnings_in_test_suite
Oct 24, 2018
Merged

Improvement: MNT: don't use filter_warnings in test suite.#3459
stefanv merged 1 commit intoscikit-image:masterfrom
hmaarrfk:dont_use_filter_warnings_in_test_suite

Conversation

@hmaarrfk
Copy link
Copy Markdown
Member

@hmaarrfk hmaarrfk commented Oct 9, 2018

Follows the tips from the the script @stefanv linked to in this post
#3438 (comment)

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • Consider backporting the PR with @meeseeksdev backport to v0.14.x

@pep8speaks
Copy link
Copy Markdown

Hello @hmaarrfk! Thanks for submitting the PR.

Line 18:80: E501 line too long (80 > 79 characters)

@hmaarrfk hmaarrfk force-pushed the dont_use_filter_warnings_in_test_suite branch from 58cf469 to 3b28956 Compare October 9, 2018 11:59
@codecov-io

This comment has been minimized.

@soupault soupault added action: mrg+1 🔧 type: Maintenance Refactoring and maintenance of internals labels Oct 23, 2018
@stefanv stefanv merged commit 97d63d9 into scikit-image:master Oct 24, 2018
@hmaarrfk hmaarrfk deleted the dont_use_filter_warnings_in_test_suite branch November 4, 2018 13:26
@hmaarrfk hmaarrfk changed the title MNT: don't use filter_warnings in test suite. Improvement: MNT: don't use filter_warnings in test suite. Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔧 type: Maintenance Refactoring and maintenance of internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants