Build tools: Fix PyQt installed in minimum requirements build#3432
Merged
soupault merged 3 commits intoscikit-image:masterfrom Oct 4, 2018
Merged
Build tools: Fix PyQt installed in minimum requirements build#3432soupault merged 3 commits intoscikit-image:masterfrom
soupault merged 3 commits intoscikit-image:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
This was referenced Sep 30, 2018
9ee0248 to
3a63a69
Compare
soupault
reviewed
Oct 4, 2018
| echo Build or run examples | ||
| pip install --retries 3 -q -r ./requirements/docs.txt | ||
| pip list | ||
| tools/build_versions.py |
Member
There was a problem hiding this comment.
This looks redundant, doesn't it?
Member
Author
There was a problem hiding this comment.
I think both are useful. build_versions gives us a quick at a glance look of what we installed. pip list is very verbose. Maybe putting it in
section "examples.install.dependencies"
pip install --retries 3 -q -r ./requirements/docs.txt
pip list
tools/build_versions.py
section_end "examples.install.dependencies"
would help clarify things?
|
|
||
| section "list.installed.dependencies" | ||
| pip list | ||
| tools/build_versions.py |
Member
Author
There was a problem hiding this comment.
QT isn't included in the requirements file, so to see what was installed, I had to use the pip list command.
Member
Author
There was a problem hiding this comment.
Maybe it would be clearer if this was moved to the install section?
stefanv
approved these changes
Oct 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somewhere along the last few maintenance PRs the MINIMUM_REQUIREMENTS broke.
See this build that failed
https://travis-ci.org/scikit-image/scikit-image/jobs/435259570
Hopefully the build process will be a little more normalized after this.
MINIMUM_REQUIREMENTSis just really fragile....For reviewers
(Don't remove the checklist below.)
later.
__init__.py.doc/release/release_dev.rst.@meeseeksdev backport to v0.14.x