Merged
Conversation
…a tuple add notes in changelog
For all except `_regular_grid.py`.
|
Hello @jni! Thanks for updating the PR.
Comment last updated on August 02, 2018 at 10:51 Hours UTC |
soupault
approved these changes
Aug 2, 2018
Member
soupault
left a comment
There was a problem hiding this comment.
@jni Awesome, thanks a ton! https://github.com/scikit-image/scikit-image/pull/3238/files#diff-0bace9c9189d4081a21cb11700e3d833R39 <- this change is missing, otherwise 👍.
Member
Author
|
@soupault oops! Fixed! |
Member
Member
Author
Member
Member
Author
We all have the same powers, but we endeavour to use them responsibly. =) By an unwritten agreement that needs to become written (I alluded to this in my roadmap proposal), we only merge after two reviews. But the backporting/LTS thing is new and we don't have a policy for these. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See #3238 for details.
@soupault it was only four commits so I just cherry-picked them individually. I agree that merge commits are messy. =)