refactor: improve ak.to_cudf errors and documentation#3850
refactor: improve ak.to_cudf errors and documentation#3850ikrommyd merged 4 commits intoscikit-hep:mainfrom
ak.to_cudf errors and documentation#3850Conversation
ak.to_cudf implementation and documentationak.to_cudf errors and documentation
Codecov Report❌ Patch coverage is
Additional details and impacted files
🚀 New features to boost your workflow:
|
|
The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3850 |
|
@ianna all the converters use Edit: |
Are we testing for all these? |
|
In general yes. Of course we don't test all possible inputs in every high-level function since they all call or to a torch tensor This is why I claim that my docstring changes here are correct and they were just an inconsistency with the rest of the dcostrings. If the input to a highlevel function already is an awkward array or layout, it's a no-op. |
ianna
left a comment
There was a problem hiding this comment.
@ikrommyd - thanks for double checking! Indeed, the functions take all these including the ArrayBuilder:
>>> builder = ak.ArrayBuilder()
>>> ak.to_torch(builder)
tensor([], dtype=torch.float64)Please merge it if you are done with it. Thanks!
We improve the the
to_cudfimplementation with appropriate import error check forcudf, proper error for unsupportedcudfversions and we also improve its docstring. Finally we fix the cudf documentation by addingak.to_cudfproperly to the api reference tree.