Skip to content

fix: use set_mask instead of set_base_mask in to_cudf#3847

Merged
ikrommyd merged 2 commits intoscikit-hep:mainfrom
ikrommyd:fix-cudf
Feb 5, 2026
Merged

fix: use set_mask instead of set_base_mask in to_cudf#3847
ikrommyd merged 2 commits intoscikit-hep:mainfrom
ikrommyd:fix-cudf

Conversation

@ikrommyd
Copy link
Copy Markdown
Collaborator

@ikrommyd ikrommyd commented Feb 5, 2026 •
edited
Loading

set_base_mask has been deleted in cudf v26.02.00 but we can use set_mask instead which is not inplace. It's not a new method and is backwards compatible with cudf before 25.12.00 which is when the column constructors have changed.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 5, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.65%. Comparing base (02d8408) to head (d1d1881).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/awkward/contents/bitmaskedarray.py 0.00% 1 Missing ⚠️
src/awkward/contents/bytemaskedarray.py 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
src/awkward/contents/bitmaskedarray.py 70.02% <0.00%> (ø)
src/awkward/contents/bytemaskedarray.py 88.38% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ikrommyd ikrommyd requested a review from ianna February 5, 2026 17:01
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 5, 2026

The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3847

@ikrommyd ikrommyd mentioned this pull request Feb 5, 2026
Merged
@ikrommyd ikrommyd requested a review from ariostas February 5, 2026 18:06
ariostas
ariostas reviewed Feb 5, 2026
View reviewed changes
@ikrommyd
Copy link
Copy Markdown
Collaborator Author

ikrommyd commented Feb 5, 2026 •
edited
Loading

FYI, in main cudf they introduce a new required null_count argument to this method that asks the user to manually provide the number of null elements of the mask. It currently calculates that automatically. Idk why. This will break again in a future cudf release 😃 Nothing I can do about that now though but the RAPIDS stack internal changes are annoying very frequently.

@ikrommyd ikrommyd merged commit 303bcdd into scikit-hep:main Feb 5, 2026
59 of 62 checks passed
@ikrommyd ikrommyd deleted the fix-cudf branch February 5, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ariostas ariostas ariostas approved these changes

@ianna ianna Awaiting requested review from ianna

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ikrommyd @ariostas