chore: do not skip test_recordarray_argmax_y_field and make the xfail reason consistent for test_listarray_sort in tests-cuda/test_3459_virtualarray_with_cuda.py#3837
Merged
ikrommyd merged 3 commits intoscikit-hep:mainfrom Feb 4, 2026
Conversation
test_recordarray_argmax_y_field in tests-cuda/test_3459_virtualarray_with_cuda.pytest_recordarray_argmax_y_field and make the xfail reason conssitent for test_listarray_sort in tests-cuda/test_3459_virtualarray_with_cuda.py`
test_recordarray_argmax_y_field and make the xfail reason conssitent for test_listarray_sort in tests-cuda/test_3459_virtualarray_with_cuda.py`test_recordarray_argmax_y_field and make the xfail reason conssitent for test_listarray_sort in tests-cuda/test_3459_virtualarray_with_cuda.py`
test_recordarray_argmax_y_field and make the xfail reason conssitent for test_listarray_sort in tests-cuda/test_3459_virtualarray_with_cuda.py`test_recordarray_argmax_y_field and make the xfail reason conssitent for test_listarray_sort in tests-cuda/test_3459_virtualarray_with_cuda.py
test_recordarray_argmax_y_field and make the xfail reason conssitent for test_listarray_sort in tests-cuda/test_3459_virtualarray_with_cuda.pytest_recordarray_argmax_y_field and make the xfail reason consistent for test_listarray_sort in tests-cuda/test_3459_virtualarray_with_cuda.py
|
The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3837 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I know, on the x-field tests should be skipped there. The y-field tests are fine and do not error. The exact same test for argmin is not skipped.
Also the reason
test_listarray_sortfails is the same as many other tests in the same file so they should have the same xfail reason.