Skip to content

chore: use "M8" dtype instead of "<M8" in tests#3819

Merged
ikrommyd merged 1 commit intoscikit-hep:mainfrom
ikrommyd:convert-test-M8-dtypes
Jan 25, 2026
Merged

chore: use "M8" dtype instead of "<M8" in tests#3819
ikrommyd merged 1 commit intoscikit-hep:mainfrom
ikrommyd:convert-test-M8-dtypes

Conversation

@ikrommyd
Copy link
Copy Markdown
Collaborator

Towards #3630
M8 is <M8 on little-endian systems.

In [3]: np.dtype("<M8[D]")
Out[3]: dtype('<M8[D]')

In [4]: np.dtype("M8[D]")
Out[4]: dtype('<M8[D]')

Since we want to properly support and test big-endian systems, we get the chore out of the way to not ask explicitly for little-endian dtypes for no reason in the tests.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.61%. Comparing base (2e25dd1) to head (561f0ab).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ikrommyd
Copy link
Copy Markdown
Collaborator Author

There are literally no changes here, I just did a find-replace "<M8" -> "M8" so I'll just wait a day and then merge this one.

@ikrommyd ikrommyd changed the title chore: use M8 dtype instead of <M8 in tests chore: use "M8" dtype instead of "M8" in tests Jan 24, 2026
@ikrommyd ikrommyd changed the title chore: use "M8" dtype instead of "M8" in tests chore: use "M8" dtype instead of "<M8" in tests Jan 24, 2026
@github-actions
Copy link
Copy Markdown

The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3819

Copy link
Copy Markdown
Member

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikrommyd - Great! Thanks for fixing it - it's definitely a step in the right direction. Please, go ahead and merge it if you have finished with it. Thanks.

@ikrommyd
Copy link
Copy Markdown
Collaborator Author

I’ll wait for you to make the releases first @ianna. Thanks!

@ikrommyd ikrommyd merged commit 680ab6e into scikit-hep:main Jan 25, 2026
41 of 42 checks passed
@ikrommyd ikrommyd deleted the convert-test-M8-dtypes branch January 25, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants