fix: pass the right input type to awkward_NumpyArray_subrange_equal* kernels#3818
Merged
ikrommyd merged 3 commits intoscikit-hep:mainfrom Jan 28, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
|
The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3818 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
awkward_NumpyArray_subrange_equalandawkward_NumpyArray_subrange_equal_boolexpect a boolean as their last argument (see their signature). However here we pass in an int64 zero which the kernel will cast to bool, the kernel will change the first byte of this (leaving the other 7 bytes untouched) and then numpy will interpret the result as int64 (as theis_equalarray's dtype does not change). This does not generally work on all systems.We here pass the correct (expected) dtype to the kernel.