fix: fix and test Form.length_zero/one_array()#3810
fix: fix and test Form.length_zero/one_array()#3810pfackeldey merged 8 commits intoscikit-hep:mainfrom
Form.length_zero/one_array()#3810Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
|
The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3810 |
|
There's still some problems |
|
I found the current logic with |
Form.length_zero/one_array() and add testsForm.length_zero/one_array()
pfackeldey
left a comment
There was a problem hiding this comment.
Thanks @ikrommyd, this fixes and allows way more length 0/1 creations from forms than before. This is only needed in 'side-stepping typetracer code' with dak.map_partitions, so could you quickly confirm that this doesn't break any existing tests we have in coffea (and maybe dask-awkward)?
I have ran dask-awkward, uproot, and coffea tests locally with this with no issues. Integration tests CI will test it even better after merging too. |
|
Thanks for checking! 👍 |
Fixes #3808
While testing, I found many other issues too (half of the added tests pass on main). This fixes them and tests them.