Skip to content

fix: make named axis thread-safe and start testing using multiple threads in CI#3805

Merged
ikrommyd merged 9 commits intoscikit-hep:mainfrom
ikrommyd:thread-safety-tests
Jan 24, 2026
Merged

fix: make named axis thread-safe and start testing using multiple threads in CI#3805
ikrommyd merged 9 commits intoscikit-hep:mainfrom
ikrommyd:thread-safety-tests

Conversation

@ikrommyd
Copy link
Copy Markdown
Collaborator

@ikrommyd ikrommyd commented Jan 18, 2026

Fixes #3802
Closes #3803

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 18, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.61%. Comparing base (7661d5a) to head (49ee9a6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
src/awkward/_namedaxis.py 91.28% <100.00%> (+0.09%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 18, 2026

The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3805

ikrommyd
ikrommyd commented Jan 18, 2026
View reviewed changes
ikrommyd
ikrommyd commented Jan 18, 2026
View reviewed changes
ikrommyd
ikrommyd commented Jan 18, 2026
View reviewed changes
ikrommyd
ikrommyd commented Jan 18, 2026
View reviewed changes
ikrommyd
ikrommyd commented Jan 18, 2026
View reviewed changes
ikrommyd
ikrommyd commented Jan 18, 2026
View reviewed changes
ianna
ianna reviewed Jan 19, 2026
View reviewed changes
pfackeldey
pfackeldey approved these changes Jan 20, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@pfackeldey pfackeldey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me know! I'm approving the python side here that makes things thread-safe. @ariostas could you review/approve the CI part of this PR?

ariostas
ariostas approved these changes Jan 20, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ariostas ariostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI side looks good to me! It does make sense to separate "nogil" and "basic". We should have done that before. And yeah, we should have been testing 3.14t on macOS.

@ikrommyd
Copy link
Copy Markdown
Collaborator Author

ikrommyd commented Jan 24, 2026

@henryiii said on slack this is good. Can we merge it?

@ianna
Copy link
Copy Markdown
Member

ianna commented Jan 24, 2026

@henryiii said on slack this is good. Can we merge it?

Sure, go ahead 🙌

@ikrommyd ikrommyd merged commit 2e25dd1 into scikit-hep:main Jan 24, 2026
40 checks passed
@ikrommyd ikrommyd deleted the thread-safety-tests branch January 24, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianna ianna ianna left review comments

@ariostas ariostas ariostas approved these changes

@pfackeldey pfackeldey pfackeldey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Start testing Awkward Array with parallel threads in CI Named axis is not thread-safe

4 participants

@ikrommyd @ianna @ariostas @pfackeldey