chore: request for tensorflow in requirements only if python < 3.14#3787
chore: request for tensorflow in requirements only if python < 3.14#3787ianna merged 1 commit intoscikit-hep:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
|
The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3787 |
ianna
left a comment
There was a problem hiding this comment.
This change is correct and necessary.
TensorFlow does not currently publish wheels for Python 3.14, which causes installation failures during test environment setup. Because these failures occur before the test suite runs, pytest.importorskip("tensorflow") cannot intercept them. Adding an environment marker to exclude TensorFlow on Python 3.14 is the appropriate and minimal fix.
The update:
tensorflow >= 2.12 ; python_version < "3.14"
is consistent with Awkward’s backend‑optional design and ensures that:
- CI on Python 3.14 runs cleanly
- TensorFlow‑dependent tests are skipped as intended
- No unrelated failures appear in the test matrix
- No behavior changes occur for supported Python versions
The change is isolated to test requirements and has no impact on users or packaging.
Tensorflow does not support python 3.14 and given the project's status, they will probably not support it for like a year.
We should only ask for it in requirements if python < 3.14