ci: xfail failing cudf tests until fixed#3781
Merged
ikrommyd merged 1 commit intoscikit-hep:mainfrom Dec 24, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
Collaborator
Author
|
Now the GPU tests are passing. I personally prefer a green ci a lot more than continuing to merge with failing GPU tests that we have to manually check which tests fail inside. |
|
The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3781 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the latest cudf release, the internal column constructors have changed and we've been getting 3 failing tests consistently for GPU every single time. Even though the GPU tests are not required in ci to merge, it's still hard to see if those are the tests that failed every or if a PR breaks other GPU tests until we actually go and look inside the actions log.
I think it's the safest to xfail these tests until we have a fix so that we can easily know if GPU ci is broken or not. Also it will be immediately seen if these tests start passing unexpectedly or in the PR that aims to fix them.