feat: add argmax implementation using CCCL#3777
Merged
ianna merged 21 commits intoscikit-hep:mainfrom Jan 12, 2026
Merged
Conversation
Collaborator
Author
|
Full error: |
Codecov Report❌ Patch coverage is
Additional details and impacted files
🚀 New features to boost your workflow:
|
|
The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3777 |
…maxymnaumchyk/cccl-kernel
…maxymnaumchyk/cccl-kernel
ianna
approved these changes
Jan 12, 2026
Member
ianna
left a comment
There was a problem hiding this comment.
@maxymnaumchyk - This is great! Please go ahead and merge it if you are done with it. Thanks!
Co-authored-by: Ianna Osborne <ianna.osborne@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was working on a simple test like this one just yesterday:
Now I'm getting a
NumbaNotImplementedError: input_data.dtypeerror for some reason. I'll be trying to fix this ~