chore: small inconsistency/typo with the non-jax case below#3698
Merged
ikrommyd merged 1 commit intoscikit-hep:mainfrom Oct 24, 2025
Merged
chore: small inconsistency/typo with the non-jax case below#3698ikrommyd merged 1 commit intoscikit-hep:mainfrom
ikrommyd merged 1 commit intoscikit-hep:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files
🚀 New features to boost your workflow:
|
|
The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3698 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something I accidentally introduced in #3596
To be fair, it's correct either way because
indexedoption_indexisWhich means that it has length
tagged_content.lengthso setting the item atnplike.shape_item_as_index(tagged_content.length)is just setting it at-1. It's just that I don't like seeing it be different from the non-jax case right below 😄.