fix: preserve the type when indexed by an empty array#3678
Merged
TaiSakuma merged 6 commits intoscikit-hep:mainfrom Oct 17, 2025
Merged
fix: preserve the type when indexed by an empty array#3678TaiSakuma merged 6 commits intoscikit-hep:mainfrom
TaiSakuma merged 6 commits intoscikit-hep:mainfrom
Conversation
ikrommyd
reviewed
Oct 16, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
|
The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3678 |
Member
|
@all-contributors please add @TaiSakuma for code |
Contributor
|
I've put up a pull request to add @TaiSakuma! 🎉 |
ianna
approved these changes
Oct 17, 2025
Member
ianna
left a comment
There was a problem hiding this comment.
@TaiSakuma - This looks great! Thank you. The tests pass - it's good to be merged. Please, go ahead and merge it if you are done with it. I will leave it up to you if you would like to tackle the ak.flatten issue as a separate PR. Thanks!
Member
Author
|
@ianna, thanks. I'll look into the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for part of #2377.
It fixes the problem where indexing with an empty array changes the type.
The PR includes associated tests.