Skip to content

chore: update pre-commit hooks#3671

Merged
ianna merged 15 commits intomainfrom
pre-commit-ci-update-config
Oct 13, 2025
Merged

chore: update pre-commit hooks#3671
ianna merged 15 commits intomainfrom
pre-commit-ci-update-config

Conversation

@pre-commit-ci
Copy link
Copy Markdown
Contributor

@pre-commit-ci pre-commit-ci bot commented Oct 6, 2025

@pre-commit-ci
chore: update pre-commit hooks
9fb73f8 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.12.11 → v0.13.3](astral-sh/ruff-pre-commit@v0.12.11...v0.13.3)
- [github.com/python-jsonschema/check-jsonschema: 0.33.3 → 0.34.0](python-jsonschema/check-jsonschema@0.33.3...0.34.0)
- [github.com/pre-commit/mirrors-mypy: v1.17.1 → v1.18.2](pre-commit/mirrors-mypy@v1.17.1...v1.18.2)
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 6, 2025

The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3671

@ariostas
Copy link
Copy Markdown
Member

ariostas commented Oct 13, 2025

Should I pin the cudf dependency in this PR so that the GPU tests pass?

At some point I'll work on it to make it a bit more robust by installing the dependencies with conda and so that we can test multiple versions of cuda.

@ianna
Copy link
Copy Markdown
Member

ianna commented Oct 13, 2025

Should I pin the cudf dependency in this PR so that the GPU tests pass?

At some point I'll work on it to make it a bit more robust by installing the dependencies with conda and so that we can test multiple versions of cuda.

no, it looks like cudf 25.10 is good for Python 3.13. Perhaps it a problem with pytest?

@ianna
Copy link
Copy Markdown
Member

ianna commented Oct 13, 2025

Should I pin the cudf dependency in this PR so that the GPU tests pass?
At some point I'll work on it to make it a bit more robust by installing the dependencies with conda and so that we can test multiple versions of cuda.

no, it looks like cudf 25.10 is good for Python 3.13. Perhaps it a problem with pytest?

https://docs.rapids.ai/install/

ianna
ianna approved these changes Oct 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariostas - I've added an explicit ignore to pytest import of cudf: exc_type=ImportError. It looks like it might have been failing before. We'll definitely need a proper fix sometime, not for this PR. Thanks!

@ianna ianna merged commit 6a5287c into main Oct 13, 2025
45 checks passed
@ianna ianna deleted the pre-commit-ci-update-config branch October 13, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ianna ianna ianna approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ariostas @ianna