Skip to content

feat: cuda reducers - add combinations for n>2, argmin and argmax, and fix min.#3645

Merged
ianna merged 31 commits intoscikit-hep:mainfrom
ianna:ianna/cuda_reducers_cccl
Sep 18, 2025
Merged

feat: cuda reducers - add combinations for n>2, argmin and argmax, and fix min.#3645
ianna merged 31 commits intoscikit-hep:mainfrom
ianna:ianna/cuda_reducers_cccl

Conversation

@ianna
Copy link
Copy Markdown
Member

@ianna ianna commented Sep 11, 2025

No description provided.

ianna and others added 23 commits August 18, 2025 16:46
@ianna
fix: min reducer cuda kernel updates
2f2ba94
@ianna
feat: combinations for > 2
a4a65ac
@pre-commit-ci
style: pre-commit fixes
dc5de5c
@ianna
debug it
21b3adf
@ianna
cleanup and skip failing tests
a56be37
@ianna
Merge branch 'main' into ianna/cuda_reducer_min
4adff6c
@ianna
intruduce cccl kernel
b34557f
@ianna
add argmin reducer
a1757a0
@ianna
rename
8eeddf3
argmin reducer
15d2790
enable tests for argmin - they fail for now
841bd7f
@ianna
try different algos
f89c6ef
@ianna
fix white spaces
f37201a
@ianna
fix white spaces
bce95de
@ianna
add argmin reducer
2d012b9
@ianna
remove empty comments in a cupy python wrapper
8670a37
@ianna
add argmax reducer, fix boundary
83ecad0
@ianna
argmin, argmax determinism: preferring the lower index (first occurre…
8b00b3b 
…nce)
@ianna
add argmin and argmax for complex types
224e1fa
@ianna
min reducer fix
ac4a9c2
@ianna
cleanup
72c5934
@ianna
add complex reducers
6e52bb9
@ianna
Merge branch 'main' into ianna/cuda_reducers_cccl
4965a21
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.66%. Comparing base (b749e49) to head (5337f20).
⚠️ Report is 425 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
src/awkward/_connect/cuda/__init__.py 0.00% <ø> (ø)

... and 196 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 11, 2025

The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3645

@ianna ianna requested a review from ariostas September 12, 2025 08:30
ianna
ianna commented Sep 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member Author

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariostas - Please, have a look. All tests pass on della-gpu and in the CI (also della-gpu?) This implementations were also tested by @kmohrman. Thanks!

ariostas
ariostas reviewed Sep 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ariostas ariostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some very minor comments. I didn't go through the logic of the code.

On a separate note, as far as I can tell there are is no pre-commit hook to format cpp files. Do you think it would be worth adding it (on a separate PR)?

@ikrommyd
Copy link
Copy Markdown
Collaborator

ikrommyd commented Sep 15, 2025

Hi @ianna, I remember you said last week that this is not using CCCL yet. However, I do see a a folder being started under src/awkward/_connect/cuda/cuda_cccl_kernels. Is this added here by accident or is it used somewhere I'm not seeing?

ianna and others added 2 commits September 16, 2025 11:12
@ianna
Copy link
Copy Markdown
Member Author

ianna commented Sep 16, 2025

Hi @ianna, I remember you said last week that this is not using CCCL yet. However, I do see a a folder being started under src/awkward/_connect/cuda/cuda_cccl_kernels. Is this added here by accident or is it used somewhere I'm not seeing?

Hi @ikrommyd. The plan is to build on this directory structure. This CCCL kernel can be used though it is not a default yet :-)

@ianna ianna added the pr-next-release Required for the next release label Sep 18, 2025
@ianna ianna merged commit b42b3d8 into scikit-hep:main Sep 18, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ariostas ariostas ariostas left review comments

Assignees

No one assigned

Labels

pr-next-release Required for the next release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ianna @ikrommyd @ariostas