test: test the virtual array generator before calling .shape in copy test#3631
Merged
ianna merged 1 commit intoscikit-hep:mainfrom Aug 26, 2025
Merged
test: test the virtual array generator before calling .shape in copy test#3631ianna merged 1 commit intoscikit-hep:mainfrom
.shape in copy test#3631ianna merged 1 commit intoscikit-hep:mainfrom
Conversation
Collaborator
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out by @ariostas, the order of the recently merged PRs combined with not rebasing before merging broke a test.
This fixes it. We test the generator before calling
.shapeas that will call the generator if there is no shape generator and change it toassert_never.