ci: doc previews for PRs from forks#3625
Conversation
|
At the time the deployment failed on forks because we don't provision credentials -- |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files🚀 New features to boost your workflow:
|
|
@agoose77 Okay, that makes sense. We could consider looking for alternatives. For example, we could use Netlify for live previews and GH pages for the "real" documentation. And that way we could ditch AWS. Netlify has a free tier that seems good. But I'll look at other alternatives. EDIT: Cloudflare pages looks pretty good. I'll look into that. |
|
I couldn't get it to work with Cloudflare since they don't have doxygen avaliable. I think Netlify could work, but I don't know if the free plan would be limiting. So I guess let's stick with AWS. I think we can get this to work with |
|
The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3625 |
|
@ianna can you remove "Deploy Branch Preview" from the required checks? Since that is now in a separate workflow it won't show up here. |
Since we're switching to a fork-based workflow we'll need to adapt the docs preview job so that it works on PRs from forks.
There was a comment saying that it can only be deployed for PRs on host repo, so I'm not sure if something will fail or if it was a self-imposed restriction.