Skip to content

fix: catch off-by-one out of bound error#3621

Merged
ianna merged 2 commits intomainfrom
agoose77/fix-ragged-kernel-error
Aug 26, 2025
Merged

fix: catch off-by-one out of bound error#3621
ianna merged 2 commits intomainfrom
agoose77/fix-ragged-kernel-error

Conversation

@agoose77
Copy link
Copy Markdown
Collaborator

Closes #2619

@pfackeldey #3619 (comment) pointed out the location, I just made the patch.

Copy link
Copy Markdown
Member

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agoose77 - Great. Thanks for fixing it!

@ianna ianna added the pr-next-release Required for the next release label Aug 15, 2025
@pfackeldey pfackeldey self-requested a review August 15, 2025 12:29
@pfackeldey
Copy link
Copy Markdown
Collaborator

Hi @agoose77, thanks!!

just linking the correct issue: closes #3619.

Could you add tests on the python side?
If you want me to do that, please let me know and I'll take this over 👍

@ariostas ariostas linked an issue Aug 15, 2025 that may be closed by this pull request
@agoose77
Copy link
Copy Markdown
Collaborator Author

@pfackeldey please take this one over the line, time is short on the ground this week!

Copy link
Copy Markdown
Collaborator

@pfackeldey pfackeldey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, no problem. I added the test @agoose77.
This is ready from my side too now 👍

@ianna ianna merged commit b5813aa into main Aug 26, 2025
46 checks passed
@ianna ianna deleted the agoose77/fix-ragged-kernel-error branch August 26, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-next-release Required for the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected fancy indexing behavior

3 participants