Conversation
pfackeldey
left a comment
There was a problem hiding this comment.
Thanks!
-8k lines of code 🎉
This and the fact that Jax backend was cumbersome will definitely help to simplify development in the future.
I've added my comments to the review. One thing that I'm missing so far is removal of JAX from the docs, and pointing people to the last awkward release in the docs that contains the JAX backend, and/or the awkward-jax branch.
|
|
||
|
|
||
| @high_level_function() | ||
| def from_jax( |
There was a problem hiding this comment.
I don't think we should get rid of this function. We still want to support converting a jax array to an awkward array with e.g. cpu backend, we're just getting rid of jax internally in awkward.
There was a problem hiding this comment.
Thanks, I agree. I was debating if it is useful to keep these high level functions.
There was a problem hiding this comment.
This and the ak.to_jax implementation do not need the jax backend/nplike. We can restore their behavior without reintroducing all of that code. (we should for sure get rid of the jax backend & nplike)
cd5755c to
f29d29b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files
🚀 New features to boost your workflow:
|
|
@pfackeldey – Let’s postpone this until after the +1 release (around the end of October). I’ll close my PR for now. |
use
awkward-jaxbranch for further development