Skip to content

fix: ak.any and ak.combinations with cuda backend kernels#3561

Merged
ianna merged 5 commits intoscikit-hep:mainfrom
ianna:ianna/any_and_combinations_on_gpu_fix
Jul 15, 2025
Merged

fix: ak.any and ak.combinations with cuda backend kernels#3561
ianna merged 5 commits intoscikit-hep:mainfrom
ianna:ianna/any_and_combinations_on_gpu_fix

Conversation

@ianna
Copy link
Copy Markdown
Member

@ianna ianna commented Jun 27, 2025

fixes #3503

Copy link
Copy Markdown
Member Author

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR should fix the issue

@ianna ianna requested a review from ariostas June 27, 2025 21:43
@ianna ianna changed the title fix: any and combinations cuda kernels fix: ak.any and ak.combinations with cuda backend kernels Jun 27, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.40%. Comparing base (b749e49) to head (bca3297).
Report is 379 commits behind head on main.

Additional details and impacted files

see 195 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@ariostas ariostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but it would be useful if someone more familiar with this side of Awkward could take a look.

Also, are there any tests for this? If #3503 is not testable with kernel tests, then maybe it would be good to add a test to tests-cuda.

@ianna ianna merged commit 87920a3 into scikit-hep:main Jul 15, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discrepancy in behavior of ak.any() for GPU backend

2 participants