fix: use older manylinux for CPython 3.10 and 3.9#3558
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
|
Hey @henryiii, is it possible for you to briefly explain this pr for my benefit? I'm looking to follow the changes! |
henryiii
left a comment
There was a problem hiding this comment.
For more on cibuildwheel 3.0, see https://iscinumpy.dev/post/cibuildwheel-3-0-0/.
| """] | ||
| skip = [ | ||
| "pp*win*", | ||
| "pp*-manylinux_i686", |
There was a problem hiding this comment.
We don't build with 32-bit linux by default anymore in cibuildwheel (and we weren't doing it at all here anyway, like in most packages).
| "pp*-manylinux_i686", | ||
| ] | ||
| test-skip = [ | ||
| "*universal2:arm64", |
There was a problem hiding this comment.
We should be building a pair of native wheels, not universal2. Just old cleanup.
|
|
||
| [[tool.cibuildwheel.overrides]] | ||
| select = "cp313*" | ||
| environment.PYO3_USE_ABI3_FORWARD_COMPATIBILITY = "1" |
There was a problem hiding this comment.
Shouldn't be needed anymore, from early 3.13 days. Cleanup.
| [[tool.cibuildwheel.overrides]] | ||
| select = "cp313*" | ||
| environment.PYO3_USE_ABI3_FORWARD_COMPATIBILITY = "1" | ||
| UV_ONLY_BINARY = "cmake,numpy" |
There was a problem hiding this comment.
This is probably a good idea, since we use build[uv] some of the time, and the variable has this name there.
| select = "*pyodide*" | ||
| build-frontend = {name = "build", args = ["--exports", "whole_archive"]} | ||
|
|
||
| # Use older manylinux for Python 3.9 and 3.10 |
There was a problem hiding this comment.
This is the 3.0 default change; we are going back to the old manylinux_2014 for 3.9 and 3.10 to reduce issues if someone is running CentOS 7-like machines with older Python. NumPy moved to 2_28 too in the last release, but NumPy only supports 3.11+.
| "ignore:Jitify is performing a one-time only warm-up", | ||
| ] | ||
| log_cli_level = "info" | ||
| log_cli_level = "INFO" |
There was a problem hiding this comment.
The SchemaStore schema for this expects upper case. You can see this with uvx sp-repo-review[all] . or at https://learn.scientific-python.org/development/guides/repo-review/.
|
I'm also working on getting pybind11 3.0 out, but haven't moved over to it here yet since it's not out yet (PyTorch is currently blocking the release). That's needed for Python 3.14, iOS, and GraalPy. |
As discussed. Minor cleanup as well.