fix: too many dashes in jupyter repr#3552
Merged
pfackeldey merged 7 commits intomainfrom Jun 18, 2025
Merged
Conversation
Collaborator
|
Hi @pfackeldey, It helps but I think it's still too many in certain cases. For the same example from the issue: 
Ideally, it should be as long as the array display right above it right? |
Collaborator
Author
|
Could you try again @ikrommyd ? |
Collaborator
|
Now I'm getting this. Reduced fields of the record array as well :). I'm happy if that's the intended result. |
Collaborator
Author
that was intended, however that only works for the most outer level of fields. At arbitrary depths is non-trivial and I'd say over-engineering. My view is either have this reduced field repr or none. |
ianna
approved these changes
Jun 18, 2025
Member
ianna
left a comment
There was a problem hiding this comment.
@pfackeldey - Thank you! Looks great! Please merge if you finished with it. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Hopefully) closes #3529.
@ianna & @ikrommyd can you give this a try?