fix: error if a complex JAX arrays type is passed to Awkward's C++ kernels#3546
Merged
pfackeldey merged 4 commits intomainfrom Jun 14, 2025
Merged
Conversation
…Awkward's C++ kernels
…Awkward's C++ kernels
…s' of github.com:scikit-hep/awkward into pfackeldey/jax_error_differentiating_through_cpp_kernels
ianna
approved these changes
Jun 14, 2025
Member
ianna
left a comment
There was a problem hiding this comment.
@pfackeldey - thanks! Looks great! Please merge it if you finished with it. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3541.
Let's error instead of silently skipping the Awkward C++ kernel call (and thus returning wrong zeros)
Example error with this PR:
Making Awkward's C++ kernels differentiable with JAX is quite complicated. If we ever want to do that we'd have to define per kernel the forward and backward differentiation implementation, and properly pass the dual number (primal & tangent) that's passed by JAX to the kernel through those. Alternatively, we could try expressing those kernels with JAX own primitives that define those implementations already - not sure if that is possible for all kernels though.