fix: improve type consistency in to_packed for num_none#3538
Merged
Conversation
Member
Author
import awkward as ak
import numpy as np
content = ak.contents.NumpyArray(np.array([0.0, 1.1, 2.2, 3.3, 4.4]))
index = ak.index.Index64(np.array([2, 2, 0, -1, 4], dtype=np.int64))
array = ak.contents.IndexedOptionArray(index, content)
array.to_packed() |
ariostas
reviewed
Jun 12, 2025
ianna
commented
Jun 12, 2025
Member
Author
ianna
left a comment
There was a problem hiding this comment.
I think, the only part which is relevant here is the change in the IndexedOptionArray.
to_packed for num_none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that the variable
num_nonein theto_packedmethod consistently holds a plain Pythonint, regardless of the nplike backend (NumPy, CuPy, JAX, etc.). This prevents potential type issues or unexpected behavior when performing downstream operations that expect a nativeint.