Skip to content

test: add cuda tests for virtual arrays#3459

Merged
ikrommyd merged 17 commits intomainfrom
ikrommyd/virtual-array-cuda-tests
Oct 24, 2025
Merged

test: add cuda tests for virtual arrays#3459
ikrommyd merged 17 commits intomainfrom
ikrommyd/virtual-array-cuda-tests

Conversation

@ikrommyd
Copy link
Copy Markdown
Collaborator

@ikrommyd ikrommyd commented Apr 12, 2025

Adds cuda tests for virtual arrays.
Apart from that, it tests almost all high level operations on a few layout types.
The fact that the buffers are virtual just tests the virtual array class additionally
The buffer/cupy/kernel stuff are tested either way. Virtual or not.
So, those are important tests to add anyways.

@ikrommyd ikrommyd marked this pull request as ready for review April 28, 2025 14:43
@ikrommyd ikrommyd requested a review from ianna April 28, 2025 14:43
Copy link
Copy Markdown
Member

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikrommyd - I get 95 failing tests:

FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_numpy_array_pad_none - ValueError: Negative dimensions are not allowed
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_numpyarray_fill_none - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_numpyarray_firsts - IndexError: cannot slice NumpyArray (of length 1) with 282578783305729: Index 282578783305729 is out of bounds for ...
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_numpyarray_singletons - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_numpyarray_cartesian - AssertionError: assert False
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_numpyarray_argcartesian - AssertionError: assert False
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_numpyarray_combinations - AssertionError: assert False
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_numpyarray_nan_to_none - ValueError: Negative dimensions are not allowed
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_numpyarray_local_index - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_to_buffers - assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_concatenate - AssertionError: broadcast_tooffsets64 can only be used with offsets that start at 0, not 4539628428701270273
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_where - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_num - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_count_nonzero - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_sum - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_nansum - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_prod - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_nanprod - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_all - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_min - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_nanmin - ValueError: Negative dimensions are not allowed
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_max - cupy.cuda.memory.OutOfMemoryError: Out of memory allocating 36,028,797,018,963,968 bytes (allocated so far: 5,632 b...
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_nanmax - ValueError: Negative dimensions are not allowed
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_is_none - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_drop_none - ValueError: Negative dimensions are not allowed
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_pad_none - ValueError: Negative dimensions are not allowed
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_firsts - ValueError: Negative dimensions are not allowed
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_cartesian - AssertionError: broadcast_tooffsets64 can only be used with offsets that start at 0, not 8589934593
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_argcartesian - AssertionError: broadcast_tooffsets64 can only be used with offsets that start at 0, not 1
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_combinations - AssertionError: assert False
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_argcombinations - AssertionError: assert False
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_nan_to_none - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_local_index - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listoffsetarray_mask_operations - AssertionError: broadcast_tooffsets64 can only be used with offsets that start at 0, not 4607182423111827713
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_to_list - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_to_json - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_to_numpy - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_zip - cupy.cuda.memory.OutOfMemoryError: Out of memory allocating 49,539,595,901,075,456 bytes (allocated so far: 2,560 b...
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_unzip - AssertionError: broadcast_tooffsets64 can only be used with offsets that start at 0, not 16843009
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_concatenate - cupy.cuda.memory.OutOfMemoryError: Out of memory allocating 80,614,433,329,932,288 bytes (allocated so far: 9,216 b...
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_where - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_flatten - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_unflatten - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_num - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_count - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_count_nonzero - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_sum - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_nansum - ValueError: Negative dimensions are not allowed
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_prod - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_nanprod - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_any - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_all - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_min - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_max - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_nanmax - cupy.cuda.memory.OutOfMemoryError: Out of memory allocating 36,028,797,018,963,968 bytes (allocated so far: 8,192 b...
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_drop_none - ValueError: Negative dimensions are not allowed
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_pad_none - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_fill_none - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_firsts - ValueError: Negative dimensions are not allowed
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_to_regular - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_broadcast_arrays - AssertionError: assert not True
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_cartesian - AssertionError: broadcast_tooffsets64 can only be used with offsets that start at 0, not 8589934593
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_argcartesian - ValueError: Negative dimensions are not allowed
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_combinations - AssertionError: assert False
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_argcombinations - AssertionError: assert False
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_nan_to_none - ValueError: Negative dimensions are not allowed
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_local_index - cupy.cuda.memory.OutOfMemoryError: Out of memory allocating 49,539,595,901,075,456 bytes (allocated so far: 6,656 b...
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_run_lengths - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_isclose - AssertionError: broadcast_tooffsets64 can only be used with offsets that start at 0, not 4608236261112822104
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_almost_equal - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_slicing - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_mask_operations - AssertionError: broadcast_tooffsets64 can only be used with offsets that start at 0, not 1
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_arithmetics - AssertionError: assert False
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_to_buffers - assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_concatenate - OverflowError: can't convert negative value to size_t
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_where_y_field - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_count_x_field - AssertionError: assert False
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_count_y_field - assert array(4607632778762754458) == array(0)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_count_nonzero_y_field - assert array(4591870180066957722) == array(0)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_sum_x_field - AssertionError: assert False
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_any_x_field - AssertionError: assert False
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_any_y_field - assert array(False) == array(True)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_max_y_field - assert array(0.) == array(1.1)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_local_index_x_field - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_local_index_y_field - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_combinations_x_field - OverflowError: can't convert negative value to size_t
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_combinations_y_field - AssertionError: assert False
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_nan_to_none_x_field - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_nan_to_none_y_field - ValueError: Negative dimensions are not allowed
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_mask_operations - OverflowError: can't convert negative value to size_t
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_firsts_x_field - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_firsts_y_field - IndexError: cannot slice NumpyArray (of length 1) with 4607632778762754458: Index 4607632778762754458 is out of bou...
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_with_custom_generator - AssertionError: assert False
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_with_none_values - AssertionError: assert [{'x': [5.5, ...], 'y': None}] == [{'x': [6.6, ...], 'y': None}]
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_recordarray_advanced_indexing - IndexError: cannot slice RecordArray (of length 5) with array([281474993488128,          -65275,               1])
===================================== 95 failed, 119 passed, 26 skipped in 14.41s ======================================

@ikrommyd
Copy link
Copy Markdown
Collaborator Author

ikrommyd commented Apr 30, 2025

@ianna What if you run them sequentially? pytest tests-cuda and not use pytest-xdist with python -m pytest -n auto tests-cuda? I was getting such weird errors as well with parallelization.

@ikrommyd
Copy link
Copy Markdown
Collaborator Author

The only error from the above that I'm expecting is ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

@ikrommyd
Copy link
Copy Markdown
Collaborator Author

On my machine I'm getting this with python -m pytest -n auto tests-cuda/test_3459_virtualarray_with_cuda.py or python -m pytest tests-cuda/test_3459_virtualarray_with_cuda.py

FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_to_list - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_to_json - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_to_numpy - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_flatten - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_unflatten - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_count - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_count_nonzero - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_sum - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_prod - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_any - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_all - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_min - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_max - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_to_regular - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_broadcast_arrays - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_run_lengths - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_almost_equal - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_slicing - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
======================================================================================================================================== 18 failed, 196 passed, 26 skipped in 4.41s =========================================================================================================================================

@ikrommyd
Copy link
Copy Markdown
Collaborator Author

With python -m pytest tests-cuda I'm getting the same 18 failed as above but with python -m pytest -n auto tests-cuda I'm getting some more errors similar to what you've encountered.

FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_numpy_array_pad_none - ValueError: Negative dimensions are not allowed
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_numpyarray_fill_none - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_numpyarray_firsts - IndexError: cannot slice NumpyArray (of length 1) with 4658907843817111553: Index 4658907843817111553 is out of bounds for axis 0 with size 1
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_numpyarray_singletons - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_to_numpy - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_to_list - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_numpyarray_local_index - AssertionError: assert array(False)
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_count - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_to_json - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_count_nonzero - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_broadcast_arrays - AssertionError: broadcast_tooffsets64 can only be used with offsets that start at 0, not 4311810305
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_to_regular - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_max - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_sum - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_any - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_flatten - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_run_lengths - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_slicing - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_all - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_cartesian - cupy.cuda.memory.OutOfMemoryError: Out of memory allocating 397,803,306,929,356,800 bytes (allocated so far: 10,240 bytes).
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_unflatten - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_prod - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_min - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_almost_equal - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_argcartesian - ValueError: Negative dimensions are not allowed
FAILED tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_combinations - AssertionError: assert False
======================================================================================================================================== 26 failed, 880 passed, 41 skipped in 8.21s =========================================================================================================================================

Copy link
Copy Markdown
Member

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikrommyd - I'm afraid, I cannot merge this PR with failing tests. Please, skip the tests that are waiting for the fix. Thanks!

@ikrommyd ikrommyd marked this pull request as draft May 1, 2025 16:38
@ikrommyd
Copy link
Copy Markdown
Collaborator Author

ikrommyd commented May 1, 2025

Needs #3468 to be resolved

@ikrommyd
Copy link
Copy Markdown
Collaborator Author

ikrommyd commented Jun 17, 2025

@ariostas @ianna, Now that the GPU CI is up, should we xfail the failing tests are try to merge this too? It's testing many aspects of the cuda backend (every high-level function) in the process while testing virtual arrays :)

@ikrommyd
Copy link
Copy Markdown
Collaborator Author

I'm also seeing some "illegal memory access was encountered" errors in CI now. I had seen these on my local desktop in the past only when I parallelized the cuda tests with pytest -n auto. I'm pretty sure this is a pytest artifact and that we won't get these if we run the tests individually. I will try to see what's up using an FNAL GPU.

@ianna ianna added the pr-inactive A pull request that hasn't been touched in a long time label Aug 14, 2025
@ariostas
Copy link
Copy Markdown
Member

Seems like it's working better with the new CI setup. As far as I can tell, the remaining errors are just from the warning of VirtualArray being deprecated in favor of VirtualNDArray.

@ikrommyd
Copy link
Copy Markdown
Collaborator Author

ikrommyd commented Oct 16, 2025

Seems like it's working better with the new CI setup. As far as I can tell, the remaining errors are just from the warning of VirtualArray being deprecated in favor of VirtualNDArray.

Yeah let me do a find-replace. This hasn't been untouched for quite some time.

@github-actions
Copy link
Copy Markdown

The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3459

@ikrommyd
Copy link
Copy Markdown
Collaborator Author

@ariostas there's still the The truth value of an array with more than one element is ambiguous. Use a.any() or a.all() error which should be fixed in cupy 14 via cupy/cupy#9089

@ikrommyd
Copy link
Copy Markdown
Collaborator Author

I xfailed the expected failing tests. It's fine now on my machine. Maybe we can actually merge this soon? @ianna

tests-cuda/test_3459_virtualarray_with_cuda.py .......................ssssss.................................................ssssss...............................x......xx.xxx.x.xxx.x.ssssss...............x...................................ssssssss......................................                      [100%]

================================================================================================================================================= short test summary info ==================================================================================================================================================
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:469: awkward_reduce_argmin is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:477: awkward_reduce_argmin is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:485: awkward_reduce_argmax is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:493: awkward_reduce_argmax is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:501: awkward_sort is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:512: awkward_argsort is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:1131: awkward_reduce_argmin is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:1141: awkward_reduce_argmin is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:1183: awkward_reduce_argmax is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:1193: awkward_reduce_argmax is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:1235: awkward_sort is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:1246: awkward_argsort is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:2123: awkward_reduce_argmin is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:2131: awkward_reduce_argmin is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:2183: awkward_reduce_argmax is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:2191: awkward_reduce_argmax is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:2243: awkward_sort is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:2254: awkward_argsort is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:3289: awkward_reduce_argmin is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:3303: awkward_reduce_argmin is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:3317: awkward_reduce_argmax is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:3331: awkward_reduce_argmax is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:3345: awkward_sort is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:3359: awkward_sort is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:3373: awkward_argsort is not implemented
SKIPPED [1] tests-cuda/test_3459_virtualarray_with_cuda.py:3387: awkward_argsort is not implemented
XFAIL tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_to_numpy - Fails due to CuPy issue: https://github.com/cupy/cupy/issues/9089
XFAIL tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_flatten - Fails due to CuPy issue: https://github.com/cupy/cupy/issues/9089
XFAIL tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_unflatten - Fails due to CuPy issue: https://github.com/cupy/cupy/issues/9089
XFAIL tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_count - Fails due to CuPy issue: https://github.com/cupy/cupy/issues/9089
XFAIL tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_count_nonzero - Fails due to CuPy issue: https://github.com/cupy/cupy/issues/9089
XFAIL tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_sum - Fails due to CuPy issue: https://github.com/cupy/cupy/issues/9089
XFAIL tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_prod - Fails due to CuPy issue: https://github.com/cupy/cupy/issues/9089
XFAIL tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_any - Fails due to CuPy issue: https://github.com/cupy/cupy/issues/9089
XFAIL tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_all - Fails due to CuPy issue: https://github.com/cupy/cupy/issues/9089
XFAIL tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_min - Fails due to CuPy issue: https://github.com/cupy/cupy/issues/9089
XFAIL tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_max - Fails due to CuPy issue: https://github.com/cupy/cupy/issues/9089
XFAIL tests-cuda/test_3459_virtualarray_with_cuda.py::test_listarray_run_lengths - Fails due to CuPy issue: https://github.com/cupy/cupy/issues/9089
======================================================================================================================================= 202 passed, 26 skipped, 12 xfailed in 4.71s ========================================================================================================================================

@ikrommyd
Copy link
Copy Markdown
Collaborator Author

@ikrommyd ikrommyd marked this pull request as ready for review October 16, 2025 17:44
@ikrommyd ikrommyd removed the pr-inactive A pull request that hasn't been touched in a long time label Oct 16, 2025
@ikrommyd ikrommyd requested a review from ianna October 16, 2025 17:44
Copy link
Copy Markdown
Member

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikrommyd - Thanks, please enable the tests. Thanks.

Copy link
Copy Markdown
Member

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikrommyd - Looks great! Thanks! Please merge it if you are done with it. Thanks.

@ianna ianna added the pr-next-release Required for the next release label Oct 24, 2025
@ikrommyd ikrommyd merged commit 8fb578b into main Oct 24, 2025
40 checks passed
@ikrommyd ikrommyd deleted the ikrommyd/virtual-array-cuda-tests branch October 24, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-next-release Required for the next release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants