fix: update backport for changes in Numba, NumExpr, Arrow, and RDataFrame#2735
fix: update backport for changes in Numba, NumExpr, Arrow, and RDataFrame#2735
Conversation
|
With or without this PR (that is, |
…g because it's correct in the real Awkward 2.x
…/scikit-hep/awkward into ianna/numba-error-backport-to-v1
jpivarski
left a comment
There was a problem hiding this comment.
I'm self-reviewing this because I don't think there's anything a second pair of eyes can add.
- @ianna updated all Numba errors to
NumbaTypeErrorandNumbaValueError, like #2659. - I updated our NumExpr interface like #2617.
- I updated our pyarrow-Parquet interface to allow
.list.elementin addition to.list.item, similar to #2670. - I dropped failing RDataFrame tests without investigating why they were failing. This is only in the
_v2subdirectory, which no one should be using now: the 1.x backport is for using 1.x. If anyone is using 2.x interfaces, they should be using Awkward 2.x.
After merging this into main-v1, I'll also publish a release as 1.10.5.
Codecov Report
Additional details and impacted files |
|
I know that the Windows 32-bit wheels build and are successfully tested from those builds. https://github.com/scikit-hep/awkward/actions/runs/6410147455/job/17402806110?pr=2735 There is no reason to struggle with build-test.yml, to get its Windows to see the correct version of Python when wheels.yml does it correctly. So I'll just remove the 32-bit test from build-test.yml and merge. |
|
I like the −68,438 :-) |
|
Oh yeah, I ran into a few problems with v2 tests failing, and this is v1, so I just dropped all of the tests. In principle, I could drop the You had me wondering, for a moment, whether there was an integer wrap-around error, since -68,438 looks a bit like |
address issue #2734