Skip to content

fix: TypeTracerArray binary operators, ak.Array.__str__ with a typetracer, attempts to call touch_data on non-typetracers, ...?#2115

Merged
jpivarski merged 8 commits intomainfrom
jpivarski/fix-up-typetracers-2023-01-12
Jan 13, 2023
Merged

fix: TypeTracerArray binary operators, ak.Array.__str__ with a typetracer, attempts to call touch_data on non-typetracers, ...?#2115
jpivarski merged 8 commits intomainfrom
jpivarski/fix-up-typetracers-2023-01-12

Conversation

@jpivarski
Copy link
Copy Markdown
Member

@jpivarski jpivarski commented Jan 12, 2023

No description provided.

@jpivarski jpivarski linked an issue Jan 12, 2023 that may be closed by this pull request
Implement all ufuncs in TypeTracerArray (was: ak.num(array, axis=1)) #1997
Closed
@jpivarski jpivarski changed the title fix: TypeTracerArray binary operators, ak.Array.__str__ with a typetracer, ...? fix: TypeTracerArray binary operators, ak.Array.__str__ with a typetracer, attempts to call touch_data on non-typetracers, ...? Jan 12, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 12, 2023 •
edited
Loading

Codecov Report

Merging #2115 (4e2099c) into main (e3f2213) will increase coverage by 0.04%.
The diff coverage is 30.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/_util.py 73.75% <4.68%> (-8.32%) ⬇️
src/awkward/record.py 82.51% <75.00%> (-0.22%) ⬇️
src/awkward/highlevel.py 76.86% <91.66%> (+0.64%) ⬆️
src/awkward/_connect/numpy.py 93.52% <100.00%> (+24.56%) ⬆️
src/awkward/_prettyprint.py 70.96% <100.00%> (+0.68%) ⬆️
src/awkward/_typetracer.py 61.57% <100.00%> (+0.54%) ⬆️

@jpivarski jpivarski temporarily deployed to docs-preview January 12, 2023 22:18 — with GitHub Actions Inactive
@jpivarski jpivarski linked an issue Jan 12, 2023 that may be closed by this pull request
ListOffsetArray type tracers (from form) raise exception when printing #2042
Closed
@pre-commit-ci pre-commit-ci bot temporarily deployed to docs-preview January 12, 2023 22:45 Inactive
@jpivarski jpivarski changed the title fix: TypeTracerArray binary operators, ak.Array.__str__ with a typetracer, attempts to call touch_data on non-typetracers, ...? fix: TypeTracerArray binary operators, ak.Array.__str__ with a typetracer, ak.is_none, attempts to call touch_data on non-typetracers, ...? Jan 12, 2023
@jpivarski jpivarski changed the title fix: TypeTracerArray binary operators, ak.Array.__str__ with a typetracer, ak.is_none, attempts to call touch_data on non-typetracers, ...? fix: TypeTracerArray binary operators, ak.Array.__str__ with a typetracer, attempts to call touch_data on non-typetracers, ...? Jan 12, 2023
@jpivarski jpivarski mentioned this pull request Jan 12, 2023
Closed
@jpivarski jpivarski linked an issue Jan 12, 2023 that may be closed by this pull request
ak.is_none raising on typetracer array input #1864
Closed
@jpivarski jpivarski temporarily deployed to docs-preview January 12, 2023 23:27 — with GitHub Actions Inactive
@jpivarski
Copy link
Copy Markdown
Member Author

jpivarski commented Jan 12, 2023

The only one of those (the previous commit) was in src/awkward/_connect/numpy.py:

% fgrep -r '.touch_data(' src --include='*.py'
src/awkward/contents/bitmaskedarray.py:            self._mask.data.touch_data()
src/awkward/contents/listarray.py:            self._starts.data.touch_data()
src/awkward/contents/listarray.py:            self._stops.data.touch_data()
src/awkward/contents/numpyarray.py:            self._data.touch_data()
src/awkward/contents/indexedarray.py:            self._index.data.touch_data()
src/awkward/contents/unionarray.py:            self._tags.data.touch_data()
src/awkward/contents/unionarray.py:            self._index.data.touch_data()
src/awkward/contents/listoffsetarray.py:            self._offsets.data.touch_data()
src/awkward/contents/indexedoptionarray.py:            self._index.data.touch_data()
src/awkward/contents/bytemaskedarray.py:            self._mask.data.touch_data()
src/awkward/_typetracer.py:            self._report.touch_data(self._form_key)
src/awkward/_typetracer.py:        self.touch_data()
src/awkward/_typetracer.py:                self.touch_data()
src/awkward/_typetracer.py:            self.touch_data()
src/awkward/_typetracer.py:            self.touch_data()
src/awkward/_typetracer.py:            self.touch_data()
src/awkward/_typetracer.py:        self.touch_data()
src/awkward/_typetracer.py:        self.touch_data()
src/awkward/_typetracer.py:        self.touch_data()
src/awkward/_typetracer.py:        self.touch_data()
src/awkward/_typetracer.py:        self.touch_data()
src/awkward/_typetracer.py:        self.touch_data()
src/awkward/_typetracer.py:        self.touch_data()
src/awkward/_typetracer.py:        self.touch_data()
src/awkward/_typetracer.py:        array.touch_data()
src/awkward/_typetracer.py:            x.touch_data()
src/awkward/_typetracer.py:            y.touch_data()
src/awkward/_typetracer.py:            x.touch_data()
src/awkward/_typetracer.py:            y.touch_data()
src/awkward/_typetracer.py:            x.touch_data()
src/awkward/_typetracer.py:            y.touch_data()
src/awkward/_typetracer.py:            x.touch_data()
src/awkward/_connect/numpy.py:                        x.data.touch_data()

@jpivarski jpivarski requested a review from agoose77 January 12, 2023 23:30
@jpivarski jpivarski temporarily deployed to docs-preview January 12, 2023 23:40 — with GitHub Actions Inactive
agoose77
agoose77 reviewed Jan 12, 2023
View reviewed changes
@jpivarski @agoose77
Use backend="typetracer" instead of building the typetracer manually.
4e2099c 
Co-authored-by: Angus Hollands <goosey15@gmail.com>
@jpivarski jpivarski temporarily deployed to docs-preview January 13, 2023 00:08 — with GitHub Actions Inactive
@jpivarski jpivarski enabled auto-merge (squash) January 13, 2023 00:08
@jpivarski jpivarski merged commit 0030145 into main Jan 13, 2023
@jpivarski jpivarski deleted the jpivarski/fix-up-typetracers-2023-01-12 branch January 13, 2023 00:17
@jpivarski jpivarski mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agoose77 agoose77 agoose77 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@jpivarski @agoose77