Merged
Conversation
69882e7 to
540a231
Compare
henryiii
commented
Jan 20, 2023
|
|
||
| if session.posargs: | ||
| if "--serve" in session.posargs: | ||
| print("Launching docs at http://localhost:8000/ - use Ctrl-C to quit") |
Collaborator
Author
There was a problem hiding this comment.
Oh, wow, auto fixing no print statements might be something to turn off. But that's easy to do in Ruff. :)
Contributor
There was a problem hiding this comment.
Huh that seems a bit aggressive!
henryiii
commented
Jan 20, 2023
| version.source = "vcs" | ||
| build.hooks.vcs.version-file = "src/scikit_build_core/_version.py" | ||
|
|
||
| [tool.hatch.build.force-include] |
Collaborator
Author
There was a problem hiding this comment.
This is working around a bug in the TOML crate for Rust, see astral-sh/ruff#1894.
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
540a231 to
c225d32
Compare
Codecov Report
@@ Coverage Diff @@
## main #175 +/- ##
==========================================
+ Coverage 90.13% 90.29% +0.15%
==========================================
Files 44 44
Lines 1855 1844 -11
==========================================
- Hits 1672 1665 -7
+ Misses 183 179 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
henryiii
commented
Jan 20, 2023
henryiii
commented
Jan 20, 2023
Collaborator
Author
|
pre-commit.ci autofix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying this out. Very impressed so far. Some minor issues, but very complete, fast, and simple. No more
.flake8file!