docs: use moderncmakedomain, Sphinx 4#574
Merged
henryiii merged 3 commits intoscikit-build:masterfrom Aug 9, 2021
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables the use of Sphinx 4. The copy of
docs/cmake.pyfrom CMake has been replaced withsphinxcontrib-moderncmakedomain, which is a port of that file to PyPI, and is much more up-to-date (from CMake 3.19, whereas our copy was much other and didn't support Sphinx 4). Really, it seems like something like that could be maintained as part of scikit-build; curious to know @slurps-mad-rips's opinion on that. We usesphinxcontrib-moderncmakedomainin pybind11.This also pins docutils, as docutils 0.17 is not compatible with sphinx-rtd-theme currently. I'd really like to move away from the rtd theme for this and other reasons.
Requested in #573.