Skip to content

refactor: use src/{package} layout#145

Merged
henryiii merged 1 commit intoscikit-build:masterfrom
mayeut:refactor-use-src-layout
Jun 2, 2021
Merged

refactor: use src/{package} layout#145
henryiii merged 1 commit intoscikit-build:masterfrom
mayeut:refactor-use-src-layout

Conversation

@mayeut
Copy link
Copy Markdown
Contributor

@mayeut mayeut commented May 24, 2021

This helps ensure what's being tested when installing the sdist or wheel and one wants to run tests on those installed packages on their own.

@mayeut mayeut mentioned this pull request May 24, 2021
@mayeut mayeut force-pushed the refactor-use-src-layout branch from fc2d020 to 850e987 Compare May 24, 2021 10:25
@mayeut mayeut force-pushed the refactor-use-src-layout branch from 850e987 to b246c7e Compare May 29, 2021 10:55
@henryiii
Copy link
Copy Markdown
Contributor

henryiii commented May 29, 2021

Any thoughts, @jcfr or @thewtex? Otherwise I'd like to merge.

Personally, I'm already a huge fan of src layout, for the same reason as listed above; it's too easy to accidentally test the in-directory version instead of the installed version. src layout forces you to either use the packaging mechanisms or be completely intentional about running from a directory. This is really important if it is a built package.

@mayeut mayeut force-pushed the refactor-use-src-layout branch 4 times, most recently from cc453fe to beb1b64 Compare May 30, 2021 16:37
@mayeut mayeut force-pushed the refactor-use-src-layout branch from beb1b64 to 7928288 Compare June 2, 2021 06:04
@henryiii henryiii merged commit 7361bd3 into scikit-build:master Jun 2, 2021
@jcfr
Copy link
Copy Markdown
Contributor

jcfr commented Jun 2, 2021

forces you to either use the packaging mechanisms or be completely intentional about running from a directory. This is really important if it is a built package.

Makes sense. Moving forward, I will adopt a similar structure for our projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants