CI: use numpy printoptions in testing#211
Merged
pllim merged 1 commit intoscientific-python:mainfrom Aug 1, 2023
Merged
Conversation
pllim
reviewed
Aug 1, 2023
Contributor
pllim
left a comment
There was a problem hiding this comment.
Should we define a NUMPY_LT_2 or something so it is easy to grep in the future when we bump minversion?
Member
Author
I think this is an overkill until we need to use the version conditional at multiple places. |
Member
Author
|
(also, note numpy is not really a dependency, we just use it for the tests, so its minversion is a bit of a grey zone.) |
pllim
approved these changes
Aug 1, 2023
Contributor
pllim
left a comment
There was a problem hiding this comment.
CI is green, so merging. Thanks!
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets rid of the testing failure. Whether to have a directive to accept multiple repr ways or not is a separate question and if the answer is yes, that should come in a separate enhancement PR.