improve the documentation of the action#23
Merged
keewis merged 8 commits intoscientific-python:mainfrom Sep 14, 2023
Merged
Conversation
Contributor
Author
|
cc @jrbourbeau, I hope you don't mind me using |
jrbourbeau
reviewed
Sep 13, 2023
Contributor
jrbourbeau
left a comment
There was a problem hiding this comment.
No problem at all! Only suggestion would be to point to an already closed issue : )
Contributor
|
Btw, I wrote a short blogpost about how we're using this over in the Dask / Coiled blogs that give you a shoutout https://blog.dask.org/2023/04/18/dask-upstream-testing. I can't remember if I sent you this already or not -- hope that's okay |
Co-authored-by: James Bourbeau <jrbourbeau@users.noreply.github.com>
Contributor
Author
|
I don't remember whether you pinged me regarding that, but I do remember reading that blog post and being happy that the action is useful for other people. In other words, yes, that's totally okay! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far the documentation was pretty minimal: a simple example, no explanation of the options, no real-world examples.