Add option to set CircleCI domain#78
Merged
bsipocz merged 3 commits intoscientific-python:masterfrom Jul 19, 2025
Merged
Conversation
f710876 to
1c9eeef
Compare
bsipocz
reviewed
Jul 18, 2025
action.yml
Outdated
| description: 'The name of the job, as it will render on the PR GUI (default is "<name of CI job> artifact)"' | ||
| required: false | ||
| domain: | ||
| description: 'The domain on which CircleCI artifacts are hosted. Defaults to output.circle-artifacts.com.' |
Member
There was a problem hiding this comment.
Should we have some docs here about the proxy or only in the docs repo?
bsipocz
approved these changes
Jul 19, 2025
Member
bsipocz
left a comment
There was a problem hiding this comment.
Tried and tested in a repo using this branch and it all works beautifully. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in support of using our new CircleCI proxy at https://circle.scientific-python.dev
See motivation at https://github.com/scientific-python/circleci-proxy
I do not know how to test the modifications I made here 🤔 @larsoner?
EDIT: Well, the fact that I managed to break the action, observe the breakage, and fix it again makes me feel more confident :)
EDIT: I've confirmed that this works by using it in stefanv/myst-preview#2