ENH: Use version for autofix-ci and add automerge#74
Merged
larsoner merged 2 commits intoscientific-python:masterfrom May 20, 2025
Merged
ENH: Use version for autofix-ci and add automerge#74larsoner merged 2 commits intoscientific-python:masterfrom
larsoner merged 2 commits intoscientific-python:masterfrom
Conversation
bsipocz
approved these changes
May 20, 2025
Member
bsipocz
left a comment
There was a problem hiding this comment.
One comment otherwise look good.
Dependabot automerge with branch protection sounds reasonable.
Co-authored-by: Brigitta Sipőcz <b.sipocz@gmail.com>
Member
|
would you mind if we tag a new version now or once the remaining fix is merged? |
Collaborator
Author
|
We can do it now, version numbers are cheap |
Collaborator
Author
|
... Do you want to do it? If not I can hopefully tomorrow |
Member
|
Sure, easy peasy. I'll bump a minor version, and with the pr in it can bump the patch straight away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bsipocz feel free to merge if you're happy
(2) has saved me a lot of time in other repos when dependabot opens PRs. I added branch protection rules to make sure the status update passes and that CircleCI passes, which should hopefully be enough. And in any rare case where it's not, it's easy enough to revert a merged PR.