Skip to content

Add GitHub Tomorrow dark preview theme#273

Merged
schuyler merged 2 commits intomainfrom
claude/resolve-issue-10-e7mNd
Jan 13, 2026
Merged

Add GitHub Tomorrow dark preview theme#273
schuyler merged 2 commits intomainfrom
claude/resolve-issue-10-e7mNd

Conversation

@schuyler
Copy link
Copy Markdown
Owner

Summary

Add a new preview-pane stylesheet called "GitHub Tomorrow" that combines GitHub formatting structure with the Tomorrow color scheme, providing a dark-mode preview theme that pairs well with the Tomorrow editor theme.

Key features:

  • Dark background (#464646) lighter than editor (#2d2d2d) for visual contrast
  • Tomorrow color palette: cyan headings (#66cccc), green links (#99cc99), orange bold (#f99157), yellow italic (#ffcc66), pink blockquotes (#f2777a)
  • Full GitHub formatting: tables, code blocks, blockquotes, lists, images
  • Responsive design with print support
  • Auto-discovered by the theme system - no code changes required

Based on PR #1289 from MacDownApp/macdown by @elsiehupp

Related Issue

Related to #106

Manual Testing Plan

Setup

  1. Open MacDown 3000
  2. Go to Preferences → Rendering → CSS → select "GitHub Tomorrow"

Key Test Scenarios

  • Background/Text: Dark gray (#464646) background, light gray (#cccccc) text
  • Headings: All H1-H6 in cyan (#66cccc), H1/H2 have underlines
  • Emphasis: Bold in orange (#f99157), italic in yellow (#ffcc66)
  • Links: Green (#99cc99)
  • Blockquotes: Pink (#f2777a) text and left border
  • Code: Gray (#999999) on darker background (#2D2D2D)
  • Tables: Alternating row backgrounds (#2d2d2d / #1c1c1c)
  • Lists: Blue markers (#6699cc)

Edge Cases

  • Text selection (white on dark)
  • Responsive width behavior (centered at 854px for screens ≥914px)
  • Print preview (colors preserved)
  • Theme switching (no artifacts)

Review Notes

  • Groucho (Architect): Confirmed CSS-only addition, auto-discovered by theme system
  • Chico (Code Review): Fixed 4 issues - CSS syntax error, blockquote color, duplicate property, file permissions
  • Harpo (Documentation): No documentation updates needed
  • Zeppo (Testing): Provided comprehensive manual testing plan

Add a new preview-pane stylesheet that combines GitHub formatting
structure with the Tomorrow color scheme. This provides a dark-mode
preview theme that pairs well with the Tomorrow editor theme.

Key features:
- Dark background (#464646) lighter than editor (#2d2d2d) for contrast
- Tomorrow color palette: cyan headings, green links, orange bold, etc.
- Full GitHub formatting: tables, code blocks, blockquotes, lists
- Responsive design with print support

Based on PR #1289 from MacDownApp/macdown by @elsiehupp

Related to #106
Address code review feedback:
- Fix font-style: bold → font-weight: bold (CSS syntax error)
- Fix blockquote color #cc99cc → #f2777a (correct Tomorrow palette)
- Remove duplicate border-radius declaration
- Fix file permissions to 644 for consistency

Related to #106
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 13, 2026

Code Coverage Report

Current Coverage: 52.39%

Coverage Details (Summary)
Name                                                                                                                                   Coverage            
-------------------------------------------------------------------------------------------------------------------------------------- ------------------- 
MASPreferences.bundle                                                                                                                  0.00% (0/0)         
MacDown 3000.app                                                                                                                       58.66% (7529/12835) 
    /Users/runner/work/macdown3000/macdown3000/MacDown/Code/Extension/DOMNode+Text.m                                                   0.00% (0/94)        
        -[NSString(WordCount) numberOfWords]                                                                                           0.00% (0/11)        
        __36-[NSString(WordCount) numberOfWords]_block_invoke                                                                          0.00% (0/3)         
        -[NSString(WordCount) lengthWithoutNewlines]                                                                                   0.00% (0/11)        
        __44-[NSString(WordCount) lengthWithoutNewlines]_block_invoke                                                                  0.00% (0/3)         
        -[NSString(WordCount) lengthWithoutWhitespacesAndNewlines]                                                                     0.00% (0/11)        
        __58-[NSString(WordCount) lengthWithoutWhitespacesAndNewlines]_block_invoke                                                    0.00% (0/3)         
        MPGetChildrenNodetextCount                                                                                                     0.00% (0/6)         
        MPGetNodeTextCount                                                                                                             0.00% (0/38)        
        -[DOMNode(Text) textCount]                                                                                                     0.00% (0/8)         
    /Users/runner/work/macdown3000/macdown3000/MacDown/Code/Document/MPDocument.m                                                      55.25% (953/1725)   
        MPEditorPreferenceKeyWithValueKey                                                                                              85.71% (6/7)        
        MPEditorKeysToObserve                                                                                                          100.00% (15/15)     
        __MPEditorKeysToObserve_block_invoke                                                                                           100.00% (10/10)     
        MPEditorPreferencesToObserve                                                                                                   100.00% (13/13)     
        __MPEditorPreferencesToObserve_block_invoke                                                                                    100.00% (8/8)       
        MPRectStringForAutosaveName                                                                                                    100.00% (6/6)       
        MPAreNilableStringsEqual                                                                                                       100.00% (3/3)       
        MPGetWebViewBackgroundColor                                                                                                    0.00% (0/9)         
        -[NSURL(Convert) absoluteBaseURLString]                                                                                        0.00% (0/6)         
        -[WebView(Shortcut) enclosingScrollView]                                                                                       100.00% (3/3)       
        -[MPPreferences(Hoedown) extensionFlags]                                                                                       75.00% (21/28)      
        -[MPPreferences(Hoedown) rendererFlags]                                                                                        75.00% (9/12)       
        MPGetPreviewLoadingCompletionHandler                                                                                           100.00% (25/25)     
        __MPGetPreviewLoadingCompletionHandler_block_invoke                                                                            100.00% (22/22)     
        -[MPDocument preferences]                                                                                                      100.00% (3/3)       
        -[MPDocument markdown]                                                                                                         100.00% (3/3)       
        -[MPDocument setMarkdown:]                                                                                                     100.00% (3/3)       
        -[MPDocument html]                                                                                                             0.00% (0/3)         
        -[MPDocument toolbarVisible]                                                                                                   0.00% (0/3)         
        -[MPDocument previewVisible]                                                                                                   100.00% (3/3)       
        -[MPDocument editorVisible]                                                                                                    100.00% (3/3)       
        -[MPDocument needsHtml]                                                                                                        0.00% (0/5)         
        -[MPDocument setTotalWords:]                                                                                                   0.00% (0/7)         
        -[MPDocument setTotalCharacters:]                                                                                              0.00% (0/7)         
        -[MPDocument setTotalCharactersNoSpaces:]                                                                                      0.00% (0/8)         
        -[MPDocument setAutosaveName:]                                                                                                 100.00% (4/4)       
        -[MPDocument init]                                                                                                             90.00% (9/10)       
        -[MPDocument windowNibName]                                                                                                    100.00% (3/3)       
        -[MPDocument windowControllerDidLoadNib:]                                                                                      100.00% (88/88)     
        __41-[MPDocument windowControllerDidLoadNib:]_block_invoke                                                                     100.00% (4/4)       
        -[MPDocument reloadFromLoadedString]                                                                                           100.00% (8/8)       
        -[MPDocument close]                                                                                                            0.00% (0/20)        
        +[MPDocument autosavesInPlace]                                                                                                 100.00% (2/2)       
        +[MPDocument writableTypes]                                                                                                    100.00% (3/3)       
        -[MPDocument isDocumentEdited]                                                                                                 100.00% (5/5)       

... (2440 more lines truncated)

📊 **Full coverage report available in workflow artifacts**

@schuyler schuyler merged commit 90c3a0c into main Jan 13, 2026
9 checks passed
@schuyler schuyler deleted the claude/resolve-issue-10-e7mNd branch January 13, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants