Import help.md images locally to eliminate d.pr network requests#232
Merged
Import help.md images locally to eliminate d.pr network requests#232
Conversation
The help.md file previously referenced 7 external images hosted on d.pr and macdown.app, which caused unexpected network connection prompts when opening MacDown 3000 for the first time. This change: - Downloads and imports all 7 images into MacDown/Resources/Images/ - Updates help.md to use local relative paths instead of external URLs - Adds the Images folder to the Xcode project's Copy Bundle Resources Related to #231
When bundled markdown files (help.md, contribute.md) are opened, they're copied to a temp directory. This change also copies the Images directory alongside them so relative image paths work. Related to #231
Contributor
Code Coverage ReportCurrent Coverage: 42.37% Coverage Details (Summary) |
Closed
Owner
Author
|
Built locally and confirmed that that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When MacDown 3000 opens for the first time, it triggers unexpected network requests to
d.prbecause the bundledhelp.mdfile references external screenshots hosted on that domain.This PR:
MacDown/Resources/Images/help.mdto use local relative paths instead of external URLsMPOpenBundledFile()to copy the Images directory alongside bundled markdown files so relative paths workRelated Issue
Related to #231
Changes
MacDown/Resources/Images/MacDown/Resources/help.mdMacDown 3000.xcodeproj/project.pbxprojMacDown/Code/Application/MPMainController.mManual Testing Plan
d.prormacdown.appImage Sources
docs/assets/images/