Merged
Conversation
Empty de-DE.lproj and sk-SK.lproj folders prevented macOS from falling back to the properly translated generic de.lproj and sk.lproj folders, causing the app to display in English for German and Slovak users. Related to #229
Contributor
Code Coverage ReportCurrent Coverage: 42.22% Coverage Details (Summary) |
The previous commit removed the empty localization directories, but the Xcode project still referenced them causing build failures. Related to #229
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty de-DE.lproj and sk-SK.lproj folders prevented macOS from falling back to the properly translated generic de.lproj and sk.lproj folders, causing the app to display in English for German and Slovak users.
Fixes #229