Merged
Conversation
- Use 'main' instead of 'master' (homebrew-cask's default branch) - Remove redundant 'git remote add upstream' (gh clone handles this) - Add git credential helper for HTTPS push auth - Add 'verified:' parameter to URL (required when homepage differs) - Fix commit/PR title format to match homebrew conventions
Remove automatic trigger on release publish. The workflow should be manual until the first PR is accepted by homebrew-cask maintainers. Related to #225
The token reference requires a hyphen between words/numbers. Also updates the filename to macdown-3000.rb. Related to #225
Now that the macdown-3000 cask has been accepted, document the installation option in the README and homepage. Related to #225
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issues discovered when running the homebrew-cask workflow:
maininstead ofmaster(homebrew-cask's default branch)git remote add upstream(gh clonehandles this for forks)verified:parameter to URL (required when homepage differs from download domain)cask-name versionstyle)macdown-3000token per homebrew naming conventions (hyphen required)Related to #49
Test plan