Address issue #222: Smart paste linkification for selected text#223
Merged
Address issue #222: Smart paste linkification for selected text#223
Conversation
When text is selected and an http(s) URL is pasted, the selected text is now wrapped in Markdown link format [selected text](pasted url) instead of being replaced by the URL. - Override paste: action in MPEditorView - Check for text selection and valid http/https URL in clipboard - Fall back to normal paste behavior for other cases - Undo works as single operation (NSTextView handles this automatically) Related to #222
Contributor
Code Coverage ReportCurrent Coverage: 42.52% Coverage Details (Summary) |
Owner
Author
|
Tested locally, works great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When text is selected in the editor and an http(s) URL is pasted, the selected text is now wrapped in Markdown link format
[selected text](pasted-url)instead of being replaced by the URL.This matches the behavior of VS Code, Obsidian plugins, and other Markdown editors.
Changes
paste:action in MPEditorView[selected text](url)usinginsertText:replacementRange:Related Issue
Related to #222
Manual Testing Plan
Core Scenarios
[text](url)[**bold**](url))Edge Cases (should NOT linkify)
file://URLs → normal pasteftp://or other schemes → normal pasteUndo/Redo
Regression
Review Notes
paste:in NSTextView subclass (recommended by Groucho)