Address issue #23: Hiding both editor and preview panes bug#207
Merged
Address issue #23: Hiding both editor and preview panes bug#207
Conversation
Add validation to ensure at least one pane remains visible at all times: 1. Modified validateUserInterfaceItem: to return NO (disable menu item) when hiding the last visible pane 2. Added guard in toggleSplitterCollapsingEditorPane: to early-return when hiding would leave no visible panes This prevents the bug where hiding both panes leaves the user unable to restore normal split view without menu intervention. Added comprehensive tests in MPPaneToggleTests.m covering: - Menu validation for both hide and restore operations - Toggle action no-op behavior when hiding last pane - Edge cases and headless CI compatibility Related to #23
Contributor
Code Coverage ReportCurrent Coverage: 38.07% Coverage Details (Summary) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Closes #23
Changes
MPDocument.mvalidateUserInterfaceItem:to returnNO(disable menu item) when hiding a pane would leave no visible panestoggleSplitterCollapsingEditorPane:to early-return when hiding would leave no visible panesMPPaneToggleTests.m(new file)Manual Testing Plan