Merged
Conversation
The MacDown plugin system has been removed entirely: - Delete MPPlugIn.h/.m and MPPlugInController.h/.m - Remove Plug-ins menu item from MainMenu.xib - Remove plugin constants from MPUtilities.h/.m - Clean up plugin references from project.pbxproj - Remove orphaned plugin translations from 19 localization files The plugin ecosystem was effectively dead (only 2 plugins ever created, both abandoned 6+ years ago) and added maintenance burden with no user benefit. Related to #192
Remove reference to plugins from hardened runtime exceptions example, since the plugin system has been removed. Related to #192
Contributor
Code Coverage ReportCurrent Coverage: 31.67% Coverage Details (Summary) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the MacDown plugin system entirely, as documented in issue #192.
Changes
MPPlugIn.h/.mandMPPlugInController.h/.mMainMenu.xibMPUtilities.h/.mproject.pbxprojplans/release-process.mdto remove plugin referenceRationale
The plugin ecosystem was effectively dead:
Related Issue
Related to #192
Manual Testing Plan
Setup
Test Scenarios
Edge Case (Optional)
If you have an existing
~/Library/Application Support/MacDown/PlugInsfolder:.bundlefiles exist