Fix preview pane Reload to re-render instead of loading raw markdown#204
Merged
Fix preview pane Reload to re-render instead of loading raw markdown#204
Conversation
When users right-click the preview pane and select Reload, WebKit was reloading from the base URL (the markdown file path), displaying raw markdown instead of rendered HTML. This fix intercepts the Reload context menu action via WebUIDelegate and replaces it with a custom action that calls parseAndRenderNow to properly re-render the preview. Related to #203
Contributor
Code Coverage ReportCurrent Coverage: 42.56% Coverage Details (Summary) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebUIDelegatemethod to intercept the Reload context menu itemparseAndRenderNowinstead of WebView's default reloadRelated Issue
Related to #203
Root Cause
When loading HTML into the preview WebView via
loadHTMLString:baseURL:, the base URL was set to the markdown file path. WebKit's default Reload action attempts to reload from this base URL, which returns the raw markdown file content instead of the rendered HTML.Manual Testing Plan
Edge cases: