Conversation
Contributor
Code Coverage ReportCurrent Coverage: 35.50% Coverage Details (Summary) |
This addresses the Intel-specific crash on macOS Sequoia by: 1. Adding macos-15-intel runner to CI test matrix - Tests now run on Apple Silicon (macos-14, macos-15) AND Intel (macos-15-intel) - Intel code path is now tested in CI, not just cross-compiled - Free GitHub Actions runner, available until August 2027 2. Adding architecture verification step to CI - Logs system architecture, CPU info, and macOS version - Helps verify tests run on correct architecture 3. Adding comprehensive diagnostic logging to MPPreferences - Logs all initialization steps with timestamps and thread info - Specifically instruments cleanupObsoleteAutosaveValues and migration - Logs dictionaryRepresentation calls that may hang on Intel Sequoia - Output to NSLog visible in Console.app for user diagnosis These changes enable: - Detection of Intel-specific bugs in CI before release - User-assisted diagnosis via Console.app logs - Identification of exact crash point if issue reproduces Related to #169
Updated documentation to reflect the addition of macos-15-intel runner and architecture verification step in CI. Changes: - test_coverage_improvement_plan.md: Added Intel testing to CI infrastructure - infrastructure_evaluation.md: Added macos-15-intel runner and architecture verification Related to #169
575a7ec to
8293459
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the Intel-specific crash on macOS Sequoia (#169) by adding Intel testing to CI and comprehensive diagnostic logging.
Changes
1. Add
macos-15-intelRunner to CI Test Matrix2. Add Architecture Verification Step
uname -m), CPU info, and macOS version3. Add Comprehensive Diagnostic Logging
MPPreferencesinitialization with detailed loggingcleanupObsoleteAutosaveValuesand migration methodsdictionaryRepresentationcalls that may hang on Intel SequoiaTesting Approach
This PR enables two diagnostic paths:
Expected Outcomes
Related Issue
Related to #169
Notes
The diagnostic logging is intentionally verbose to help identify the crash point. Once #169 is resolved, we can reduce verbosity if needed.