Merged
Conversation
Corrects multiple French localization issues in character count strings and menu items: 1. Localizable.strings: - Fix typo "charactère" → "caractère" (lines 11, 14) - Based on MacDownApp/macdown PR #1274 by @benel 2. MainMenu.strings: - Fix mixed language "Gauche 1:1 Right" → "Gauche 1:1 Droite" - Fix verb form "Contribue à" → "Contribuer à" (infinitive) - Add missing articles "Arrêter Dictée" → "Arrêter la dictée" - Add missing articles "Démarrer Dictée" → "Démarrer la dictée" These changes improve the quality and consistency of the French localization for French-speaking users. Related to #107
Contributor
Code Coverage ReportCurrent Coverage: 41.32% Coverage Details (Summary) |
Owner
Author
|
@benel please have a look at this PR and confirm that it's correct? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes multiple French localization errors discovered during comprehensive review of French language files. Includes the original typo fix from MacDownApp/macdown PR #1274 plus additional grammar and consistency improvements.
Changes Made
1. MacDown/Localization/fr.lproj/Localizable.strings (2 fixes)
CHARACTERS_NO_SPACES_PLURAL_STRINGCHARACTERS_PLURAL_STRING2. MacDown/Localization/fr.lproj/MainMenu.strings (4 fixes)
Related Issue
Related to #107
Manual Testing Plan
Setup
Configure macOS to use French locale:
Or launch MacDown in French without changing system language:
Test Cases
1. Character Count Display (Status Bar)
2. Layout Menu (Présentation → View)
3. Help Menu (Aide)
4. Speech Menu (Édition → Dicter)
Edge Cases
open -a "MacDown 3000" --args -AppleLanguages "(en)"Review Notes
Code Review (Chico)
✅ APPROVED - All changes correct and ready to merge
Note: Chico identified a pre-existing semantic issue (unrelated to this PR): "Speech" is translated as "Dictée" (dictation) but typically means text-to-speech in macOS. Standard French term would be "Parole" or "Élocution". This is NOT a blocker and could be addressed in a separate issue if desired.
Documentation Review (Harpo)
✅ No documentation updates needed - Changes are localization-only and don't affect documented processes, testing procedures, or architecture.
Testing Plan (Zeppo)
✅ Comprehensive manual testing plan provided (see Manual Testing Plan section above)
Why These Fixes Matter
These corrections improve the user experience and professionalism of MacDown 3000 for French-speaking users.
Files Modified
MacDown/Localization/fr.lproj/Localizable.stringsMacDown/Localization/fr.lproj/MainMenu.stringsCommit: efa082c